Create and open shortcut #9890
Merged
Create and open shortcut #9890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
changed the title
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
AlexAndBear
changed the title
|
SonarCloud Quality Gate failed.
|
lookacat
approved these changes
Nov 2, 2023
| @@ -56,6 +61,12 @@ | |||
| </oc-button> | |||
| </li> | |||
| </template> | |||
| <li class="create-list-shortcut oc-menu-item-hover"> | |||
There was a problem hiding this comment.
is the create-list-shortcutused anywhere?
| @confirm="createShortcut" | ||
| > | ||
| <template #content> | ||
| url |
There was a problem hiding this comment.
Can be done in a followup but just a blank text url is a bit short for the user? At least it looked wrong to me
ownclouders
pushed a commit
that referenced
this pull request
Nov 2, 2023
12 tasks
AlexAndBear
added a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: