Allow to delete passwords on public links when password is enforced but permission is set #9857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
issues:
|
AlexAndBear
commented
Oct 24, 2023
AlexAndBear
commented
Oct 25, 2023
Comment on lines
-77
to
-96
| const passwordEnforced = | ||
| store.getters.capabilities?.files_sharing?.public?.password?.enforced_for?.read_only === | ||
| true | ||
|
|
||
| if (passwordEnforced) { | ||
| return showQuickLinkPasswordModal( | ||
| { store, $gettext: language.$gettext, passwordPolicyService }, | ||
| async (password) => { | ||
| await copyQuicklink({ | ||
| ability, | ||
| clientService, | ||
| language, | ||
| password, | ||
| resource: item, | ||
| store | ||
| }) | ||
| } | ||
| ) | ||
| } | ||
|
|
AlexAndBear
changed the title
AlexAndBear
force-pushed
the
ocis/issues/7538
branch
from
587759b
to
12abdb3
Compare
|
SonarCloud Quality Gate failed.
|
AlexAndBear
commented
Oct 26, 2023
| @@ -338,7 +342,7 @@ export default defineComponent({ | |||
| }) | |||
| } | |||
| } | |||
| if (!this.isPasswordEnforced && !this.link.password && !this.isAliasLink) { | |||
There was a problem hiding this comment.
Huh I don't get this check in the first place? If password is not enforced we don't allow the user to add a password ?
12 tasks
AlexAndBear
added a commit
that referenced
this pull request
Dec 13, 2023
…ut permission is set (#9857) * Allow to remove password on public link if permission allows * Fix bug where password prompt did instant pop up * Refactor * Remove unused capability * Fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've enabled to ability to allow delete passwords on public links, even if the password is enforced.
Therefore, the user needs respective permission, granted by the server.
This feature is only possible on public links that have the viewer role.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: