Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Set OcModal Buttons to equal width #9671

Merged
merged 8 commits into from
Sep 7, 2023
Merged

Enhancement: Set OcModal Buttons to equal width #9671

merged 8 commits into from
Sep 7, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Sep 7, 2023 •
edited
Loading

Description

See #9641

Related Issue

Screenshots (if appropriate):

Screenshot (59)
Screenshot (58)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 7, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review September 7, 2023 14:02
AlexAndBear
AlexAndBear approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uffff smart Solution

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.4% 81.4% Coverage
0.0% 0.0% Duplication

@lookacat lookacat enabled auto-merge (squash) September 7, 2023 15:16
@lookacat lookacat merged commit 6e2eb63 into master Sep 7, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enhancement-oc-modal-equal-button-width branch September 7, 2023 15:34
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@lookacat @AlexAndBear
Enhancement: Set OcModal Buttons to equal width (#9671)
83f89cf 
* Enhancement: Set OcModal Buttons to equal width

* Fix console error

* Add changelog

* Beautify code

* Beautify code

* Adjust .drone.env

* Simplify if statements

* Update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@tbsbdr tbsbdr Awaiting requested review from tbsbdr

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons Should Have Same Width
2 participants
@lookacat @AlexAndBear