Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement file locking information #9566

Merged
merged 16 commits into from
Aug 24, 2023
Merged

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Aug 10, 2023

Description

See #6682

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • batch actions disable for locked files

@update-docs
Copy link

update-docs bot commented Aug 10, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review August 22, 2023 10:50
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides retrieving the lock user data

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

71.7% 71.7% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit a5cff39 into master Aug 24, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the display-locking-information branch August 24, 2023 07:43
ownclouders pushed a commit that referenced this pull request Aug 24, 2023
* Implement file locking information

* Implement lock in files-table (ugly)

* Implement lock owner in buildResource

* Display lock owner

* remove lock column

* Add changelog

* Add tooltip to reflect status

* Add aria label

* Disable move, delete, rename for locked files

* Address PR issues, add lock file

* Remove lockowner from details (for now)

* Fix misreplaced code

* Now i found the right code to remove

* Add unittests

* remove unused prop in test

* Fix acceptance tests
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
* Implement file locking information

* Implement lock in files-table (ugly)

* Implement lock owner in buildResource

* Display lock owner

* remove lock column

* Add changelog

* Add tooltip to reflect status

* Add aria label

* Disable move, delete, rename for locked files

* Address PR issues, add lock file

* Remove lockowner from details (for now)

* Fix misreplaced code

* Now i found the right code to remove

* Add unittests

* remove unused prop in test

* Fix acceptance tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show file-locking information
2 participants