Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File versions tooltip with absolute date #9441

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

elizavetaRa
Copy link
Member

@elizavetaRa elizavetaRa commented Jul 19, 2023

Description

The pr adds a tooltip with absolute date on version’s relative date in version details

Related Issue

  • Fixes <issue_link>

Motivation and Context

Users of CERNBox complain about the visibility of only relative date for versions. Showing absolute dates in tooltip would be consistent with "shared on" in shares and "modified" data

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Screenshot from 2023-07-19 07-23-08

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 19, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

The pipeline was flaky yesterday, rebasing your branch with current master should fix it.

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 5930ce9 into owncloud:master Jul 19, 2023
2 checks passed
@diocas diocas deleted the up_versions-date branch July 24, 2023 13:07
AlexAndBear pushed a commit that referenced this pull request Aug 15, 2023
* file versions tooltip with absolute date

* add changelog
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
* file versions tooltip with absolute date

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants