Fix glitchy left sidebar when switching apps #7529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
commented
Aug 25, 2022
| @@ -149,7 +147,7 @@ export default { | |||
| max-width: 230px !important; | |||
| } | |||
| .oc-app-navigation-collapsed { | |||
| min-width: 58px !important; | |||
| max-width: 58px !important; | |||
| min-width: 62px !important; | |||
There was a problem hiding this comment.
This fixes the uneven padding which is mentioned here: #7525
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/27835/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27835/tracing/file-alice-2022-8-25-02-33-45.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27835/tracing/file-brian-2022-8-25-02-33-52.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27835/tracing/folder-alice-2022-8-25-02-32-15.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27835/tracing/folder-brian-2022-8-25-02-32-22.zip |
kulmann
approved these changes
Aug 25, 2022
|
@JammingBen e2e tests are failing for oc10 🤔 |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've fixed a bug where the active state of the left sidebar would glitch visually when switching apps.
Related Issue
Types of changes