Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resharing in e2e test #7378

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Resharing in e2e test #7378

merged 1 commit into from
Aug 4, 2022

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Aug 1, 2022

  • added api methods (for ocis and for oc10): creating group, adding user to group, deleting group

  • created "reshare with user" step

  • created "reshare with group" step (I'll do it in separate task)

  • created "share with group" step (I'll do it in separate task)

@update-docs
Copy link

update-docs bot commented Aug 1, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Aug 1, 2022

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/27317/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27317/tracing/folder-alice-2022-8-3-11-03-04.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27317/tracing/folder-brian-2022-8-3-11-03-12.zip

@ScharfViktor
Copy link
Contributor Author

test failed in this place: https://github.com/owncloud/web/blob/master/tests/e2e/support/objects/app-files/utils/sidebar.ts#L50-L53 when I try to transition in sidebar from details-> to shares

Screen.Recording.2022-08-02.at.00.25.48.mov

transition or animation different between Shares and Personal
@fschade could you look please what is problem

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Aug 2, 2022

test failed in this place: https://github.com/owncloud/web/blob/master/tests/e2e/support/objects/app-files/utils/sidebar.ts#L50-L53 when I try to transition in sidebar from details-> to shares

Screen.Recording.2022-08-02.at.00.25.48.mov
transition or animation different between Shares and Personal @fschade could you look please what is problem

it works correct without promise:

await panelSelector.click()
await locatorUtils.waitForEvent(nextPanel, 'transitionend')

instead of:

await Promise.all([locatorUtils.waitForEvent(nextPanel, 'transitionend'), panelSelector.click()])`

couldn't find a better idea. If you have, could you please share

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Aug 3, 2022

https://drone.owncloud.com/owncloud/web/27317/11/18
https://drone.owncloud.com/owncloud/web/27315/11/18

re-share tests has failed in CI for oc10. this needs to be investigated. I'll do it in new issue. In the meantime, let these tests only for ocis

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Comment on lines +48 to +50
And "Carol" reshares the following resource
| resource | user | role |
| folder_to_shared | Alice | viewer |
Copy link
Contributor

@SwikritiT SwikritiT Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know it was possible to reshare the resource to the person to whom the resource belongs with a different roles. Is this expected?

I tried to play around with the UI

  1. Alice accepts the share request
  2. Alice as the owner of the resource creates a sub folder inside folder_to_shared like test
  3. The sub-folder is displayed in shared with me inside folder_to_shared
  4. If Alice goes inside folder_to_shared->tests from shared with me (this folder is shared with role viewer), she can create resources inside it but not directly inside folder_to_shared

Probably not related to this PR. Seems like a bug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try to check this case. It's too complicated. It doesn't seem realistic.
I checked only that user can re-share re-shared resource. I did not create the 4th user

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a separate issue for this case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue created here owncloud/ocis#4336

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants