-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resharing in e2e test #7378
Resharing in e2e test #7378
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
e32ad1a
to
b924330
Compare
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/27317/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27317/tracing/folder-alice-2022-8-3-11-03-04.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27317/tracing/folder-brian-2022-8-3-11-03-12.zip |
test failed in this place: https://github.com/owncloud/web/blob/master/tests/e2e/support/objects/app-files/utils/sidebar.ts#L50-L53 when I try to transition in sidebar from details-> to shares Screen.Recording.2022-08-02.at.00.25.48.movtransition or animation different between Shares and Personal |
it works correct without promise:
instead of:
couldn't find a better idea. If you have, could you please share |
9671883
to
2cb5d6e
Compare
https://drone.owncloud.com/owncloud/web/27317/11/18 re-share tests has failed in CI for oc10. this needs to be investigated. I'll do it in new issue. In the meantime, let these tests only for ocis |
2cb5d6e
to
7f5ee34
Compare
Kudos, SonarCloud Quality Gate passed! |
And "Carol" reshares the following resource | ||
| resource | user | role | | ||
| folder_to_shared | Alice | viewer | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know it was possible to reshare the resource to the person to whom the resource belongs with a different roles. Is this expected?
I tried to play around with the UI
- Alice accepts the share request
- Alice as the owner of the resource creates a sub folder inside
folder_to_shared
liketest
- The sub-folder is displayed in shared with me inside
folder_to_shared
- If Alice goes inside folder_to_shared->tests from shared with me (this folder is shared with role viewer), she can create resources inside it but not directly inside
folder_to_shared
Probably not related to this PR. Seems like a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't try to check this case. It's too complicated. It doesn't seem realistic.
I checked only that user can re-share re-shared resource. I did not create the 4th user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create a separate issue for this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue created here owncloud/ocis#4336
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
added api methods (for ocis and for oc10): creating group, adding user to group, deleting group
created "reshare with user" step
created "reshare with group" step (I'll do it in separate task)
created "share with group" step (I'll do it in separate task)