Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Make ui small again #7363

Merged
merged 13 commits into from
Aug 20, 2022
7 changes: 7 additions & 0 deletions changelog/unreleased/enhancement-streamline-ui-sizings
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Streamline UI sizings

We've streamlined the font sizes and some other size related options to let the web UI appear a bit more condensed. In addition to that we've chosen a new font family for the UI ("Inter") which is embedded into the ownCloud Design System by default now.

https://github.com/owncloud/web/pull/7363
https://github.com/owncloud/web/issues/7333
https://github.com/owncloud/owncloud-design-system/pull/2270
42 changes: 24 additions & 18 deletions changelog/unreleased/enhancement-update-ods
Original file line number Diff line number Diff line change
@@ -1,22 +1,28 @@
Enhancement: Update ODS to v14.0.0-alpha.12
Enhancement: Update ODS to v14.0.0-alpha.16

We updated the ownCloud Design System to version 14.0.0-alpha.12. Please refer to the full changelog in the ODS release (linked) for more details. Summary:
We updated the ownCloud Design System to version 14.0.0-alpha.16. Please refer to the full changelog in the ODS release (linked) for more details. Summary:

- Bugfix - Remove click event on OcIcon: #2216
- Bugfix - Lazy loading render performance: #2260
- Bugfix - Omit special characters in user avatar initials: #2267
- Bugfix - Avatar link icon: #2269
- Bugfix - Remove width shrinking of the ocAvatarItem: #2242
- Change - Remove OcAlert component: #2210
- Change - Remove transition animations: #2210
- Change - Revamp animations: #2210
- Change - OcTable emit event data on row click: #2218
- Enhancement - OcCheckbox add outline: #2218
- Enhancement - Progress bar indeterminate state: #2200
- Enhancement - Redesign notifications: #2210
- Enhancement - Use oc colors for selected background and deselect icon: #2262
- Enhancement - Adjust avatar font weight from bold to normal: #2275
- Enhancement - Add offset property to the drop component: #2276
* Bugfix - Omit special characters in user avatar initials: [#2070](https://github.com/owncloud/owncloud-design-system/issues/2070)
* Bugfix - Avatar link icon: [#2269](https://github.com/owncloud/owncloud-design-system/pull/2269)
* Bugfix - Lazy loading render performance: [#2260](https://github.com/owncloud/owncloud-design-system/pull/2260)
* Bugfix - Remove width shrinking of the ocAvatarItem: [#2241](https://github.com/owncloud/owncloud-design-system/issues/2241)
* Bugfix - Remove click event on OcIcon: [#2216](https://github.com/owncloud/owncloud-design-system/pull/2216)
* Change - Redesign contextual helper: [#2271](https://github.com/owncloud/owncloud-design-system/pull/2271)
* Change - Remove OcAlert component: [#2210](https://github.com/owncloud/owncloud-design-system/pull/2210)
* Change - Remove transition animations: [#2210](https://github.com/owncloud/owncloud-design-system/pull/2210)
* Change - Revamp animations: [#2210](https://github.com/owncloud/owncloud-design-system/pull/2210)
* Change - OcTable emit event data on row click: [#2218](https://github.com/owncloud/owncloud-design-system/pull/2218)
* Enhancement - Add nestedd drop functionality: [#2238](https://github.com/owncloud/owncloud-design-system/issues/2238)
* Enhancement - Add OcInfoDrop: [#2286](https://github.com/owncloud/owncloud-design-system/pull/2286)
* Enhancement - Add rounded prop to OcTag: [#2284](https://github.com/owncloud/owncloud-design-system/pull/2284)
* Enhancement - Adjust avatar font weight from bold to normal: [#2275](https://github.com/owncloud/owncloud-design-system/pull/2275)
* Enhancement - OcCheckbox add outline: [#2218](https://github.com/owncloud/owncloud-design-system/pull/2218)
* Enhancement - Add offset property to the drop component: [#7335](https://github.com/owncloud/web/issues/7335)
* Enhancement - Make UI smaller: [#2270](https://github.com/owncloud/owncloud-design-system/pull/2270)
* Enhancement - OcSelect dark mode improvements: [#2262](https://github.com/owncloud/owncloud-design-system/pull/2262)
* Enhancement - Progress bar indeterminate state: [#2200](https://github.com/owncloud/owncloud-design-system/pull/2200)
* Enhancement - Redesign notifications: [#2210](https://github.com/owncloud/owncloud-design-system/pull/2210)
* Enhancement - Use Inter font: [#2270](https://github.com/owncloud/owncloud-design-system/pull/2270)

https://github.com/owncloud/web/pull/7355
https://github.com/owncloud/owncloud-design-system/releases/tag/v14.0.0-alpha.12
https://github.com/owncloud/owncloud-design-system/releases/tag/v14.0.0-alpha.16
1 change: 1 addition & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ services:
- ./dist/js:/mnt/data/apps/web/js
- ./dist/themes:/mnt/data/apps/web/themes
- ./dist/icons:/mnt/data/apps/web/icons
- ./dist/fonts:/mnt/data/apps/web/fonts
- ./dist/index.html:/mnt/data/apps/web/index.html
- ./dist/manifest.json:/mnt/data/apps/web/manifest.json
- ./dist/oidc-callback.html:/mnt/data/apps/web/oidc-callback.html
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-external/src/components/ErrorScreen.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div class="oc-text-center">
<oc-icon size="xxlarge" name="error-warning" fill-type="line" />
<p v-if="message" class="oc-text-lead">{{ message }}</p>
<p v-if="message" class="oc-text-xlarge">{{ message }}</p>
</div>
</template>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
exports[`The external app error screen component displays an icon and a paragraph 1`] = `
<div class="oc-text-center">
<ocicon-stub size="xxlarge" name="error-warning" fill-type="line"></ocicon-stub>
<p class="oc-text-lead">Error when loading the application</p>
<p class="oc-text-xlarge">Error when loading the application</p>
</div>
`;
23 changes: 13 additions & 10 deletions packages/web-app-files/src/components/ActionMenuItem.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<li>
<component
:is="action.componentType"
<oc-button
:type="action.componentType"
v-bind="getComponentProps(action, items)"
:class="[action.class, 'action-menu-item']"
data-testid="action-handler"
Expand Down Expand Up @@ -43,7 +43,7 @@
class="oc-invisible-sr"
v-text="$gettext('(Opens in new window)')"
/>
</component>
</oc-button>
</li>
</template>

Expand Down Expand Up @@ -78,21 +78,24 @@ export default {
},
methods: {
getComponentProps(action, resources) {
const props = {
appearance: this.appearance,
...(action.isDisabled && { disabled: action.isDisabled() }),
...(action.variation && { variation: action.variation })
}

if (action.componentType === 'router-link' && action.route) {
return {
...props,
to: action.route({ resources })
}
}

return {
appearance: this.appearance,
...(action.isDisabled && { disabled: action.isDisabled() }),
...(action.variation && { variation: action.variation })
}
return props
},

getComponentListeners(action, resources) {
if (typeof action.handler !== 'function' || action.componentType !== 'oc-button') {
if (typeof action.handler !== 'function' || action.componentType !== 'button') {
return {}
}

Expand Down Expand Up @@ -122,7 +125,7 @@ export default {
}
.oc-files-context-action-shortcut {
justify-content: right !important;
font-size: 0.85rem;
font-size: var(--oc-font-size-small);
font-weight: bold !important;
opacity: 0.7;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ export default defineComponent({
}
#upload-list,
#new-file-menu-drop {
min-width: 250px;
min-width: 230px;
}
</style>
<style lang="scss">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
class="oc-text-center oc-flex-middle oc-flex oc-flex-center oc-flex-column"
>
<oc-icon name="cloud" type="div" size="xxlarge" />
<div class="oc-text-muted oc-text-large">
<div class="oc-text-muted oc-text-xlarge">
<translate>Resource not found</translate>
</div>
<div class="oc-text-muted">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,9 @@ export default defineComponent({
opacity: 0.6;
}
&-resource-wrapper {
display: flex;
align-items: center;

&-limit-max-width {
max-width: calc(100% - var(--oc-space-medium));
}
Expand All @@ -821,7 +824,7 @@ export default defineComponent({
}
&-edit-name {
display: inline-flex;
vertical-align: super;
margin-left: var(--oc-space-xsmall);
svg {
fill: var(--oc-color-text-muted);
}
Expand Down
8 changes: 0 additions & 8 deletions packages/web-app-files/src/components/Search/Preview.vue
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,3 @@ export default {
}
}
</script>

<style lang="scss">
.files-search-preview {
button {
font-size: 0.8rem;
}
}
</style>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div>
<h2 class="oc-px-m oc-py-s">
{{ title }}
<span class="oc-text-initial">({{ items.length }})</span>
<span class="oc-text-medium">({{ items.length }})</span>
</h2>

<no-content-message v-if="!items.length" class="files-empty oc-flex-stretch" icon="group">
Expand Down
3 changes: 1 addition & 2 deletions packages/web-app-files/src/components/SideBar/FileInfo.vue
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,9 @@ export default {

&__body {
text-align: left;
font-size: 0.75rem;

h3 {
font-size: 0.9rem;
font-size: var(--oc-font-size-medium);
font-weight: 600;
margin: 0;
word-break: break-all;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
padding-size="remove"
>
<h4
class="oc-text-bold oc-text-initial oc-m-rm oc-px-m oc-pt-m oc-pb-s"
class="oc-text-bold oc-m-rm oc-px-m oc-pt-m oc-pb-s"
v-text="$gettext(customPermissionsRole.label)"
/>
<oc-list>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div id="oc-files-file-link" class="oc-position-relative">
<div class="oc-flex">
<h3 class="oc-text-bold oc-m-rm oc-text-initial" v-text="linksHeading" />
<h3 class="oc-text-bold oc-text-medium oc-m-rm" v-text="linksHeading" />
<oc-contextual-helper v-if="helpersEnabled" class="oc-pl-xs" v-bind="viaLinkHelp" />
</div>
<p
Expand Down Expand Up @@ -71,7 +71,7 @@
<div v-if="indirectLinks.length" id="indirect-link-list">
<hr class="oc-my-m" />
<div class="oc-flex">
<h3 class="oc-text-bold oc-m-rm oc-text-initial">
<h3 class="oc-text-bold oc-m-rm oc-text-medium">
<span v-text="indirectLinksHeading" />
</h3>
<oc-contextual-helper v-if="helpersEnabled" class="oc-pl-xs" v-bind="indirectLinkHelp" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div id="oc-files-sharing-sidebar" class="oc-position-relative">
<div class="oc-flex">
<h3 v-translate class="oc-text-bold oc-m-rm oc-text-initial">Share with people</h3>
<h3 v-translate class="oc-text-bold oc-text-medium oc-m-rm">Share with people</h3>
<oc-contextual-helper
v-if="helpersEnabled"
class="oc-pl-xs"
Expand All @@ -16,7 +16,7 @@
v-text="noResharePermsMessage"
/>
<div v-if="hasSharees" class="avatars-wrapper oc-flex oc-flex-middle oc-flex-between">
<h4 class="oc-text-initial oc-text-bold oc-my-rm" v-text="sharedWithLabel" />
<h4 class="oc-text-bold oc-my-rm" v-text="sharedWithLabel" />
</div>
<template v-if="hasSharees">
<ul
Expand All @@ -43,7 +43,7 @@
</div>
</template>
<template v-if="showSpaceMembers">
<h4 class="oc-text-initial oc-text-bold oc-my-s" v-text="spaceMemberLabel" />
<h4 class="oc-text-bold oc-my-s" v-text="spaceMemberLabel" />
<ul
id="space-collaborators-list"
class="oc-list oc-list-divider oc-overflow-hidden oc-m-rm"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div id="oc-files-sharing-sidebar" class="oc-position-relative">
<div class="oc-flex">
<h3 v-translate class="oc-text-bold oc-m-rm oc-text-initial">Members</h3>
<h3 v-translate class="oc-text-bold oc-text-medium oc-m-rm">Members</h3>
<oc-contextual-helper v-if="helpersEnabled" class="oc-pl-xs" v-bind="spaceAddMemberHelp" />
</div>
<invite-collaborator-form
Expand Down
4 changes: 2 additions & 2 deletions packages/web-app-files/src/components/SideBar/SpaceInfo.vue
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ export default {

&__body {
text-align: left;
font-size: 0.75rem;
font-size: var(--oc-font-size-small);

h3 {
font-size: 0.9rem;
font-size: var(--oc-font-size-medium);
font-weight: 600;
margin: 0;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-files/src/mixins/actions/acceptShare.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default {
})
return !acceptDisabled
},
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-accept-share-trigger'
}
]
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-files/src/mixins/actions/copy.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default {
// a user always has their home dir with write access
return true
},
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-copy-trigger'
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default {
}
return canShare(resources[0], this.$store)
},
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-create-quicklink-trigger'
}
]
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-files/src/mixins/actions/declineShare.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default {
})
return !declineDisabled
},
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-decline-share-trigger'
}
]
Expand Down
4 changes: 2 additions & 2 deletions packages/web-app-files/src/mixins/actions/delete.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default {
})
return !deleteDisabled
},
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-delete-trigger'
},
{
Expand All @@ -60,7 +60,7 @@ export default {
}
return resources.length > 0
},
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-delete-permanent-trigger'
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default {
return !downloadDisabled
},
canBeDefault: true,
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-download-archive-trigger'
}
]
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-files/src/mixins/actions/downloadFile.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default {
return resources[0].canDownload()
},
canBeDefault: true,
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-download-file-trigger'
}
]
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-files/src/mixins/actions/emptyTrashBin.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default {
return resources.length === 0
},
isDisabled: () => this.activeFiles.length === 0,
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-empty-trash-bin-trigger',
variation: 'danger'
}
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-files/src/mixins/actions/favorite.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default {

return this.capabilities?.files?.favorites
},
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-favorite-trigger'
}
]
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-files/src/mixins/actions/move.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default {
})
return !moveDisabled
},
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-move-trigger'
}
]
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-files/src/mixins/actions/paste.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default {
// a user always has their home dir with write access
return true
},
componentType: 'oc-button',
componentType: 'button',
class: 'oc-files-actions-copy-trigger'
}
]
Expand Down
Loading