Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add indeterminate progress bar in upload overlay #7123

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Add indeterminate progress bar in upload overlay #7123

merged 2 commits into from
Jun 14, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

We've added an indeterminate state to the progress bar in the upload overlay as long as the upload is preparing.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jun 14, 2022
@JammingBen JammingBen marked this pull request as ready for review June 14, 2022 10:36
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Jun 14, 2022
@JammingBen JammingBen force-pushed the upload-info-indeterminate-progress branch from 9ef4f31 to 7f40a46 Compare June 14, 2022 13:34
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@kulmann kulmann merged commit 1314fa0 into master Jun 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the upload-info-indeterminate-progress branch June 14, 2022 14:14
@micbar micbar mentioned this pull request Jun 22, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indeterminate progress bar while upload is being prepared
3 participants
@JammingBen @kulmann @pascalwengerter