Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Implement cut, copy, paste keyboard shortcuts #7078

Merged
merged 16 commits into from
Jun 13, 2022
Merged

[full-ci] Implement cut, copy, paste keyboard shortcuts #7078

merged 16 commits into from
Jun 13, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jun 1, 2022 •
edited
Loading

Description

See #7071

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@update-docs
Copy link

update-docs bot commented Jun 1, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Jun 1, 2022 •
edited
Loading

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/26103/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L78.png

webUISharingPublicManagement-shareByPublicLink_feature-L78.png

@lookacat lookacat force-pushed the file-keyboard-actions branch 3 times, most recently from 49b2fec to b3d4a5a Compare June 7, 2022 07:43
@lookacat lookacat force-pushed the file-keyboard-actions branch 2 times, most recently from 238a2a1 to 8e98edb Compare June 7, 2022 10:29
@lookacat lookacat changed the title Implement basic key actions Implement cut, copy, paste keyboard shortcuts Jun 9, 2022
@lookacat lookacat marked this pull request as ready for review June 9, 2022 08:34
@lookacat lookacat requested a review from kulmann June 9, 2022 08:34
@lookacat lookacat changed the title Implement cut, copy, paste keyboard shortcuts [full-ci] Implement cut, copy, paste keyboard shortcuts Jun 9, 2022
@lookacat lookacat force-pushed the file-keyboard-actions branch 3 times, most recently from 03b5d80 to 41a7d9f Compare June 9, 2022 14:20
fschade
fschade requested changes Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor findings, thanks for the pr

packages/web-app-files/src/components/FilesList/ResourceTable.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/helpers/resource/move.ts Outdated Show resolved Hide resolved
packages/web-app-files/src/helpers/resource/move.ts Show resolved Hide resolved
packages/web-app-files/src/store/actions.js Show resolved Hide resolved
packages/web-app-files/src/App.vue Outdated Show resolved Hide resolved
fschade
fschade reviewed Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found just one small dev leftover, expect that.... LGTM 🚀

packages/web-app-files/src/App.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/helpers/resource/move.ts Show resolved Hide resolved
@lookacat lookacat requested a review from fschade June 13, 2022 09:38
@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

45.3% 45.3% Coverage
0.0% 0.0% Duplication

fschade
fschade approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lookacat lookacat merged commit 9e0354e into master Jun 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the file-keyboard-actions branch June 13, 2022 10:57
@micbar micbar mentioned this pull request Jun 22, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WEB] Keyboard Shortcuts // Actions
4 participants
@lookacat @ownclouders @kulmann @fschade