Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear files searched in spaces overview #7014

Merged
merged 2 commits into from
May 19, 2022
Merged

Clear files searched in spaces overview #7014

merged 2 commits into from
May 19, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented May 19, 2022

Description

We've fixed a bug where searching for a file in the search bar messes up the spaces overview and instead of listing
the spaces, and found files according to the search term were shown.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented May 19, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Clear files searched Clear files searched in spaces overview May 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't reproduce on master but code LGTM

@AlexAndBear
Copy link
Contributor Author

@pascalwengerter

  1. Create a file name test.txt
  2. Search for file in “current folder” search instead of “all files”
  3. Hit enter to see the files list
  4. Head over to spaces

For me reproducible

@pascalwengerter
Copy link
Contributor

@pascalwengerter

1. Create a file name test.txt

2. Search for file in “current folder” search instead of “all files”

3. Hit enter to see the files list

4. Head over to spaces

For me reproducible

Oh good read it wrong then, was checking the "real search"

@AlexAndBear
Copy link
Contributor Author

@pascalwengerter can you force merge ? Liscence check is broken

@pascalwengerter
Copy link
Contributor

@pascalwengerter can you force merge ? Liscence check is broken

Nope, but I can re-run the check 😎 please squash-merge later

@AlexAndBear AlexAndBear merged commit 9423a33 into master May 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/6995 branch May 19, 2022 11:10
@kulmann kulmann mentioned this pull request May 25, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search in folder adds "ghost" spaces to the page
2 participants