Use our EventBus for upload related actions #6853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/25141/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/25141/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-5-3-07-06-44.zip |
JammingBen
force-pushed
the
uppy-event-bus
branch
2 times, most recently
from
2341772
to
1d829cb
Compare
dschmidt
requested changes
May 2, 2022
There was a problem hiding this comment.
not so sure about this.
I would just replace the internal mechanism in the uppyService, instead of using the bus everywhere
That way we can type the topics properly in the service (and also we don't import the eventbus instance everywhere, while we already inject the uppyService ...)
|
SonarCloud Quality Gate failed. |
fschade
pushed a commit
that referenced
this pull request
May 3, 2022
* Use our EventBus for upload related actions * Add changelog item * Wrap up the event methods in our uppy service * Fix unit test * Remove uploaded files from uppy before calling the success handlers
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of extending Vue, the uppy service now uses our custom
EventBus.Follow up for #6202
Related Issue