Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take path into account while renaming a file #6804

Merged
merged 6 commits into from
Apr 22, 2022
Merged

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 22, 2022

Description

Bugfix: Rename a file in the favorites list to a file with the same name but in a different folder not possible

We've fixed a bug, where renaming a file in the favorites file list to a file with the same name but in a different
folder was not possible, as the message The name "..." is already taken appeared.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Apr 22, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@pascalwengerter
Copy link
Contributor

Please squash-on-merge :)

@AlexAndBear AlexAndBear merged commit 22fac27 into master Apr 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/1750 branch April 22, 2022 13:22
@micbar micbar mentioned this pull request May 5, 2022
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to rename a file on the favorites page to a name of a file from an other folder
2 participants