Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Implement unshare confirm dialog #6795

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[full-ci] Implement unshare confirm dialog #6795

merged 1 commit into from
Apr 21, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 20, 2022 •
edited
Loading

Description

Enhancement: Add un-share confirmation dialog

We have implemented a confirmation dialog, which pops up if the user clicks the remove share button

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Apr 20, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@owncloud owncloud deleted a comment from ownclouders Apr 21, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Apr 21, 2022 •
edited
Loading

Results for oC10SharingIntGroups https://drone.owncloud.com/owncloud/web/24795/28/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L42.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L42.png

pascalwengerter
pascalwengerter approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this needs some acceptance test updates (might be worth running as full-ci also) but LGTM so far already!

changelog/unreleased/enhancement-add-unshare-confirmation-dialog Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear changed the title Implement unshare confirm dialog [full-ci] Implement unshare confirm dialog Apr 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
53.1% 53.1% Duplication

@AlexAndBear AlexAndBear merged commit eabb7f3 into master Apr 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the unshare-dialog branch April 21, 2022 12:27
@micbar micbar mentioned this pull request May 5, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove a share/space member: show confirmation dialog
3 participants
@AlexAndBear @ownclouders @pascalwengerter