Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix invisible rename is clickable on mobile #6775

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Apr 12, 2022

Description

See #6767

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Styling changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@lookacat lookacat marked this pull request as ready for review April 12, 2022 09:22
@pascalwengerter pascalwengerter force-pushed the bugfix-rename-still-clickable-on-mobile branch from 862e385 to 07e9254 Compare April 12, 2022 12:29
@pascalwengerter
Copy link
Contributor

Fixed the linting error, CI should become green now

Update changelog

Update changelog/unreleased/bugfix-rename-still-clickable-on-mobile

Rebase, dedupe deps, satisfy linter
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/24680/56/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITextEditor-textFile_feature-L29.png

webUITextEditor-textFile_feature-L29.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

Bugfix: Rename is clickable on mobile

We've fixed a bug where the quick rename button was clickable,
even so it wasn't visible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
even so it wasn't visible.
even though it wasn't visible.

@kulmann kulmann merged commit 7b14372 into master Apr 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix-rename-still-clickable-on-mobile branch April 25, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick-rename button should not be clickable on touch-devices
5 participants