-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search context menu #6445
Fix search context menu #6445
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/22825/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-06-08-35.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-file-to-brian-alice-2022-2-16-06-09-54.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-file-to-brian-brian-2022-2-16-06-09-59.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-folder-with-file-to-brian-alice-2022-2-16-06-11-07.zip |
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/22825/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-06-09-35.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-file-to-brian-alice-2022-2-16-06-11-01.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-file-to-brian-brian-2022-2-16-06-11-06.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-folder-with-file-to-brian-alice-2022-2-16-06-12-19.zip |
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/22827/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-06-52-17.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-file-to-brian-alice-2022-2-16-06-53-36.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-file-to-brian-brian-2022-2-16-06-53-40.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-folder-with-file-to-brian-alice-2022-2-16-06-54-49.zip |
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/22827/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-06-53-28.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-file-to-brian-alice-2022-2-16-06-54-58.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-file-to-brian-brian-2022-2-16-06-55-04.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-folder-with-file-to-brian-alice-2022-2-16-06-56-18.zip |
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/22830/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-07-30-59.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-file-to-brian-alice-2022-2-16-07-32-20.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-file-to-brian-brian-2022-2-16-07-32-25.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-folder-with-file-to-brian-alice-2022-2-16-07-33-34.zip |
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/22830/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-07-31-49.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-file-to-brian-alice-2022-2-16-07-33-15.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-file-to-brian-brian-2022-2-16-07-33-20.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-folder-with-file-to-brian-alice-2022-2-16-07-34-33.zip |
packages/web-app-files/src/components/FilesList/ContextActions.vue
Outdated
Show resolved
Hide resolved
00cedc3
to
e3eb3d7
Compare
e3eb3d7
to
09f154b
Compare
df3e462
to
240d2ea
Compare
240d2ea
to
33ef769
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement 🥇
SonarCloud Quality Gate failed. |
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22843/66/1
|
🤩 |
In #6445 we introduced a dependency on isFilesAppActive for the fileActions mixin. We added it to ContextActions and BatchActions, but there are way more places where the mixin is used. That's why we added a computed to the mixin itself. Because mixins belong to the options api we unfortunately cannot use composables directly and extracted helper functions for that reason.
In #6445 we introduced a dependency on isFilesAppActive for the fileActions mixin. We added it to ContextActions and BatchActions, but there are way more places where the mixin is used. That's why we add a computed to the mixin itself now. Because mixins belong to the options api we unfortunately cannot use composables directly and extracted helper functions for that reason.
In #6445 we introduced a dependency on isFilesAppActive for the fileActions mixin. We added it to ContextActions and BatchActions, but there are way more places where the mixin is used. That's why we add a computed to the mixin itself now. Because mixins belong to the options api we unfortunately cannot use composables directly and extract helper functions for that reason.
In #6445 we introduced a dependency on isFilesAppActive for the fileActions mixin. We added it to ContextActions and BatchActions, but there are way more places where the mixin is used. That's why we add a computed to the mixin itself now. Because mixins belong to the options api we unfortunately cannot use composables directly and extract helper functions for that reason.
In #6445 we introduced a dependency on isFilesAppActive for the fileActions mixin. We added it to ContextActions and BatchActions, but there are way more places where the mixin is used. That's why we add a computed to the mixin itself now. Because mixins belong to the options api we unfortunately cannot use composables directly and extract helper functions for that reason.
Description
Enable/disable certain file actions outside of the file application.
Related Issue
Motivation and Context
Several file actions (currently) work or don't work outside the files app. In general anything that just interacts with the backend works fine, actions that rely on e.g., the sidebar, don't work in the search app for instance.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks:
Decide whether we want to make the search results selectable in the ResourcesTable, to prepare for multi select and archive download.
Currently we have no search in oCIS and
isDownloadAsArchiveAvailable
is false on oC 10, so currently it's probably just confusing for no benefit... tying this toisDownloadAsArchiveAvailable
would be possible, but feels weird as well ... happy to hear other opinions :)Adding a check whether