Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Query Items #6444

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Context Query Items #6444

merged 3 commits into from
Feb 16, 2022

Conversation

dschmidt
Copy link
Member

Description

This allows to define contextQueryItems on route.meta to specify which query items of the current route should be serialized as contextQuery in app urls.

Related Issue

  • Fixes <issue_link>

Motivation and Context

On a less abstract level: this fixes closeApp in apps like the mediaviewer for search results. Without this change you are redirected to an empty search page, with this you are redirected to the original search.

How Has This Been Tested?

  • needs oC 10, because currently there is no search for oCIS
  • search for Portgual in all files, click Portugal.jpg, see mediaviewer opens and closing returns back to search

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Feb 16, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22822/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@kulmann kulmann merged commit 2ea7541 into master Feb 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the context_query_items branch February 16, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants