Implement spaces list

[JammingBen]

Description

Adds an entry point to access all available spaces for the user.

Related Issue

• Fixes Listing: Display Spaces overview #6104

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Implement suitable software architecture
• Design (?)
• Tests
• Changelog item

[JammingBen]

This is ready for a first review cycle. A few annotations:

• We're not sure about the routing. The way we implemented this causes issues with the active flag. Assuming the spaces live under /spaces/projects, this has to be fixed.
  
• The missing spaces icon in the left sidebar requires the new ODS release.
• URL for Learn more about spaces is still missing.
• Should we hide the view options?
  
• It UI Kit being removed in the near future? Then we have change the classes being used.

[kulmann]

@dragotin how's the learn more about spaces link planned? Is there already some info page on owncloud.com? Or can we at least define a URL for it (without the page actually existing) which can be placed in the code?

[kulmann]

The static nav item is an issue. We need to have an enabled spaces capability. IMO we should add an optional isEnabled callback to nav items, similar to the file action mixins. Could you look into that? Needs the store in the param object so that you can check the capabilities.

[ownclouders]

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/21530/41/1
The following scenarios passed on retry:

• webUISharingExternalToRoot/federationSharing.feature:378

[ownclouders]

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21540/15/1
The following scenarios passed on retry:

• webUISharingAcceptSharesToRoot/acceptShares.feature:108

[ownclouders]

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/21543/59/1
The following scenarios passed on retry:

• webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:136

[ownclouders]

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/21543/38/1
The following scenarios passed on retry:

• webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:286

[kulmann]

Some nitpicks. ;-)
Please rebase to current master. Icons/ODS update has been merged to web master.

In index.js of the files app you can append personal/ to the route of the All files nav item. That will fix the duplicate highlighting of active nav items in the sidebar.

[kulmann]

• Should we hide the view options?

Makes sense, yes.

• Is UI Kit being removed in the near future? Then we have change the classes being used.

Yes, planned to be removed this week. 😉 basically anything that is uk- will be oc- then AFAIK. @pascalwengerter can say more about this.

[JammingBen]

Addressed your comments 👍 Two questions left:

• See Implement spaces list #6199 (comment) -> Should we keep the spaces "header" regardless of the no-content-message? If so, it's hard to 100% center the message vertically, because height: 100% does not work. We added 50% for now, it's better, but not exactly centered.
• We removed the view options. Now the app bar is empty but still takes away some space. Okay, or hide as well? I think the spaces won't use the existing app bar at all, but rather their "own" implementation.
  

[kulmann]

• See Implement spaces list #6199 (comment) -> Should we keep the spaces "header" regardless of the no-content-message? If so, it's hard to 100% center the message vertically, because height: 100% does not work. We added 50% for now, it's better, but not exactly centered.

Awesome, looks better now. 👍

• We removed the view options. Now the app bar is empty but still takes away some space. Okay, or hide as well? I think the spaces won't use the existing app bar at all, but rather their "own" implementation.

I hope that we can use the same AppBar for spaces as for the other views, but it will probably need some restructuring. ;-) For the overview of the spaces I think we can hide it completely.

[fschade]

found some small things.
I would love to see some e2e tests as part of this pr.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

87.0% Coverage
0.0% Duplication

[kulmann]

Awesome! 💪

[kulmann]

One thing that I found is, that the spaces are neither sorted by created time, nor by name. Not an issue for this PR, but please open a ticket about default sorting or simply sort by name for now.

[refs]

why not using this?

see https://github.com/owncloud/libre-graph-api/blob/main/.drone.star#L17-L21

[JammingBen]

One thing that I found is, that the spaces are neither sorted by created time, nor by name. Not an issue for this PR, but please open a ticket about default sorting or simply sort by name for now.

I've created #6253, since we really want to merge this now as the pipeline is currently green for once :D

[AlexAndBear]

One thing that I found is, that the spaces are neither sorted by created time, nor by name. Not an issue for this PR, but please open a ticket about default sorting or simply sort by name for now.

Sorting should be a task for the API, this feature is yet not there, so we just wait until it is done and fix this in the next PR 😇

[kulmann]

Sorting should be a task for the API, this feature is yet not there, so we just wait until it is done and fix this in the next PR 😇

Yes, of course something for the API. I meant it as a mitigation for the status quo. Which is a oneliner. ;-) if sorting in the backend happens soon then it's fine.