Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Update to ODS 9.3.0 #5725

Merged
merged 3 commits into from
Sep 2, 2021
Merged

[full-ci] Update to ODS 9.3.0 #5725

merged 3 commits into from
Sep 2, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Aug 23, 2021 •
edited
Loading

Description

This PR updates ODS to v9.3.0, including required changes.

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • fix tests that use the show details button to enforce showing the right sidebar. Probably need to use the contextmenu for that now. Or a combination of selecting a resource and then toggling the sidebar.#
  • write changelog item

@update-docs
Copy link

update-docs bot commented Aug 23, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann changed the title Update to ODS 9.3.0 [full-ci] Update to ODS 9.3.0 Aug 24, 2021
@kulmann kulmann self-assigned this Aug 24, 2021
@kulmann kulmann marked this pull request as ready for review August 24, 2021 09:12
@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18550/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@ownclouders
Copy link
Contributor

Results for oC10Trashbin https://drone.owncloud.com/owncloud/web/18596/36/1
The following scenarios passed on retry:

  • webUITrashbinFilesFolders/trashbinFilesFolders.feature:38

@pascalwengerter pascalwengerter mentioned this pull request Aug 26, 2021
Closed
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/18615/24/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:104

@ownclouders
Copy link
Contributor

Results for oC10iPhone1 https://drone.owncloud.com/owncloud/web/18615/45/1
The following scenarios passed on retry:

  • webUIFilesCopy/copy.feature:10
  • webUIRenameFiles/renameFiles.feature:22

@kulmann kulmann force-pushed the update-ods-9.3.0 branch 2 times, most recently from abf1df8 to e12e900 Compare August 26, 2021 10:15
@ownclouders
Copy link
Contributor

Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/18622/46/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:14

@ownclouders
Copy link
Contributor

Results for oC10iPhone1 https://drone.owncloud.com/owncloud/web/18622/45/1
The following scenarios passed on retry:

  • webUIFilesCopy/copy.feature:10

@kulmann kulmann mentioned this pull request Aug 26, 2021
Closed
@kulmann kulmann force-pushed the update-ods-9.3.0 branch 2 times, most recently from 6f9956c to 50e8992 Compare August 26, 2021 12:10
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/18633/24/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:104

@ownclouders
Copy link
Contributor

Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/18633/46/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:14
  • webUITrashbinFilesFolders/trashbinFilesFolders.feature:23

@ownclouders
Copy link
Contributor

Results for oC10iPhone1 https://drone.owncloud.com/owncloud/web/18633/45/1
The following scenarios passed on retry:

  • webUIRenameFiles/renameFiles.feature:23

@kulmann kulmann force-pushed the update-ods-9.3.0 branch 2 times, most recently from 9b568a8 to 2d0b428 Compare August 26, 2021 14:16
@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18637/40/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18637/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@ownclouders
Copy link
Contributor

Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/18637/46/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:14

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18667/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/18714/24/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:114

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18740/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@kulmann kulmann mentioned this pull request Aug 31, 2021
Closed
@kulmann
Copy link
Member Author

kulmann commented Aug 31, 2021

cc @elizavetaRa

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18745/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18760/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

pascalwengerter
pascalwengerter approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the refactoring & code deletion!

tests/acceptance/stepDefinitions/filesContext.js Show resolved Hide resolved
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersRoot2 https://drone.owncloud.com/owncloud/web/18772/30/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootShareWithPage/shareWithUsers.feature:79

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18773/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/18773/24/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:114

@ownclouders
Copy link
Contributor

Results for oC10CreateDelete https://drone.owncloud.com/owncloud/web/18773/9/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:59

@ownclouders
Copy link
Contributor

Results for oCISSharingInternalUsers1 https://drone.owncloud.com/owncloud/web/18773/55/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:337

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18775/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18775/34/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/publicLinkIndicator.feature:110

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18775/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 57d03cf into master Sep 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-ods-9.3.0 branch September 2, 2021 10:10
@phil-davis phil-davis mentioned this pull request Sep 2, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@LukasHirt LukasHirt LukasHirt approved these changes

@fschade fschade Awaiting requested review from fschade

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kulmann @ownclouders @pascalwengerter @LukasHirt