Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltips to expandSidebar & showViewOptions #5724

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Add tooltips to expandSidebar & showViewOptions #5724

merged 1 commit into from
Aug 23, 2021

Conversation

pascalwengerter
Copy link
Contributor

Related Issue

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/18529/24/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:104

@ownclouders
Copy link
Contributor

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/18529/39/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter pascalwengerter force-pushed the add-more-tooltips branch 2 times, most recently from a4bb474 to 9f924b8 Compare August 23, 2021 17:57
@pascalwengerter
Copy link
Contributor Author

@kulmann can I get a force-merge here? CI is flaky and I didn't change anything business-logic-y (the data prop was a linter complaint)

@pascalwengerter
Copy link
Contributor Author

Supersedes #5648 (which seems to fail randomly in CI and it's not worth re-running it over and over to get a pass)

kulmann
kulmann approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit 8c58917 into master Aug 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-more-tooltips branch August 23, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tooltips are missing
3 participants
@pascalwengerter @ownclouders @kulmann