[full-ci] feat: move custom permissions to a drop

[LukasHirt]

Description

Move custom permissions to a dropdown

Screenshots

Open tasks:

• Merge [full-ci] feat: redesign recipient roles select #5632 and rebase afterwards
• Merge and release feat: drop custom target and manual mode owncloud-design-system#1575 and update ODS afterwards
• Add changelog

[fschade]

@LukasHirt i added keyboard navigation to the pr

[ownclouders]

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18937/12/1
The following scenarios passed on retry:

• webUIFilesActionMenu/versions.feature:36

[ownclouders]

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18956/34/1
The following scenarios passed on retry:

• webUISharingPublicManagement/publicLinkIndicator.feature:27

[ownclouders]

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18958/34/1
The following scenarios passed on retry:

• webUISharingPublicManagement/publicLinkIndicator.feature:27

[ownclouders]

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18962/28/1
The following scenarios passed on retry:

• webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

[ownclouders]

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18995/12/1
The following scenarios passed on retry:

• webUIFilesActionMenu/versions.feature:36

[kulmann]

Could you give the OcDrop for the custom permissions an auto width? It looks a bit weird with so much whitespace on the right side.

[LukasHirt]

Could you give the OcDrop for the custom permissions an auto width? It looks a bit weird with so much whitespace on the right side.

TBH I find it quite odd looking when using the auto width 🙈

[LukasHirt]

Maybe a bit better with the different title?

[ownclouders]

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19003/12/1
The following scenarios passed on retry:

• webUIFilesActionMenu/versions.feature:36
• webUIFilesActionMenu/versions.feature:15

[kulmann]

@tbsbdr do you have an opinion here? Regarding a) title of the custom permissions drop and b) the width (more whitespace or less whitespace)?

I'd say the most recent version is fine (Custom permissions as title and the auto-width).

Primary button could say something like Apply instead of Ok IMO.

[tbsbdr]

Yep, "apply" is better than "ok" - more precise and makes the button bigger. Ideally both buttons would have the same width. But apply works for now, thx!

[LukasHirt]

@kulmann updated the label and screenshot in the desc

[saw-jan]

@paulcod3 I'm sorry that I couldn't inform you in ocChat (cannot find you). I am looking at the webui tests that are failing.
webUISharingInternalUsersToRootCollaborator/shareWithUsers.feature tests are failing because share role cannot be changed from Custom Permissions to other roles from dropdown. But reverse will work.

[kiranparajuli589]

are these expected?

• create a share with all checkboxes selected from custom permissions, the share is displayed with the Editor role and if we see permissions list from drop: only read is checked`
• create a share with read & edit selected from custom permissions drop, the share is displayed with the Custom permissions role and if we see permissions list from drop: only read is checked`

[kiranparajuli589]

also, hovering items in invite drop makes item text invisible.

[saw-jan]

also, hovering items in invite drop makes item text invisible.

[lookacat]

@saw-jan @kiranparajuli589 thanks for the hint, the first problem could indeed be the reason for the tests to fail. The other error when hovering is just styling which we ignored for now.

[ownclouders]

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/19315/39/1
The following scenarios passed on retry:

• webUISharingExternal/federationSharing.feature:106

[kiranparajuli589]

very few failures this time.

• webUIFilesActionMenu/versions.feature:36 (pass locally)

  fails due to version count doesn't match, maybe disabling previews will solve this

• ocisSharingPermissions1-chrome
  webUISharingPermissionsUsers/sharePermissionsUsers.feature:178
  webUISharingPermissionsUsers/sharePermissionsUsers.feature:169
  webUISharingPermissionsUsers/sharePermissionsUsers.feature:243
  webUISharingPermissionsUsers/sharePermissionsUsers.feature:125

  API failure (pass locally)

[sonarcloud]

SonarCloud Quality Gate failed.   

1 Bug
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

68.0% Coverage
0.0% Duplication