Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encode app name for app provider #10983

Merged
merged 1 commit into from
Jun 1, 2024
Merged

fix: encode app name for app provider #10983

merged 1 commit into from
Jun 1, 2024

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented May 31, 2024

Description

Fixing the case that the app name for the app provider has e.g. a space in it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Copy link

update-docs bot commented May 31, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann requested a review from JammingBen May 31, 2024 13:02
@kulmann kulmann self-assigned this May 31, 2024
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kulmann kulmann merged commit 2067f9d into master Jun 1, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the encode-wopi-app-name branch June 1, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants