Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure view fixes #10973

Merged
merged 9 commits into from
Jun 3, 2024
Merged

Secure view fixes #10973

merged 9 commits into from
Jun 3, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented May 28, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented May 28, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review June 1, 2024 04:51
kulmann
kulmann approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This polishes the secure view feature nicely, thank you! 🤩 Just one nitpick for your attention, but no matter how you decide, I'll still approve.

packages/web-pkg/src/services/preview/previewService.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear enabled auto-merge (squash) June 3, 2024 08:19
@AlexAndBear AlexAndBear merged commit 36cd238 into master Jun 3, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the secure-view-fixes branch June 3, 2024 08:29
@saw-jan saw-jan mentioned this pull request Jun 3, 2024
Closed
@kulmann kulmann mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@butonic butonic Awaiting requested review from butonic

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] New Role "Secure View"
2 participants
@AlexAndBear @kulmann