Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selection after space duplication #10132

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

JammingBen
Copy link
Collaborator

Description

Spaces are listed as regular resources on the projects page, hence we need to make sure to insert duplicated spaces as such.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Spaces are listed as regular resources on the projects page, hence we need to make sure to insert duplicated spaces as such.
@JammingBen JammingBen self-assigned this Dec 8, 2023
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good finding 👍

Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 158704f into master Dec 8, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-space-selection-after-duplicating branch December 8, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No batch action buttons for duplicated spaces
2 participants