Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: showing the logout page after token expiry #10065

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Nov 24, 2023

Description

Fixes wrongly showing the logout page after revisiting Web with an expired token. Users now get redirected to the login page instead.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Nov 24, 2023
@JammingBen JammingBen force-pushed the fix-logout-page-after-token-expiry branch from 380a3fc to 796e6f5 Compare November 24, 2023 14:11
Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woaaaaaaah

@@ -265,8 +275,7 @@ export class AuthService {
await this.store.dispatch('resetUserState')
await Promise.all([
this.store.dispatch('clearDynamicNavItems'),
this.store.dispatch('hideModal'),
this.store.dispatch('clearSettingsValues')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally 😂

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@kulmann kulmann merged commit aa45300 into master Nov 27, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-logout-page-after-token-expiry branch November 27, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants