Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing passwordless link role to one that has an enforced password fails badly #6974

Closed
pascalwengerter opened this issue May 13, 2022 · 0 comments · Fixed by #6989
Closed
Assignees

Comments

@pascalwengerter
Copy link
Contributor

Steps to reproduce

  1. Set password protection to true for read-only link shares
  2. Create non-read-only link share without password, then change it to read-only via dropdown
  3. See both error and success message on the UI

Expected behaviour

See a modal that asks you to add a password since the role you're trying to change the link into requires one

Notes

Will need quite some acceptance test fixes and also take into account #6961, which will make the need to check the same condition on link creation as well

@AlexAndBear AlexAndBear self-assigned this May 17, 2022
pascalwengerter pushed a commit that referenced this issue May 18, 2022
[full-ci] Show password prompt if role change on public link enforces password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants