Add collaborators #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
requested changes
May 14, 2020
There was a problem hiding this comment.
Gherkin syntax is a little bit different :-)
https://cucumber.io/docs/gherkin/reference/
No caps on the keywords.
Thanks. Fixed. |
micbar
requested changes
May 15, 2020
| Scenario: Being removed as a collaborator from a resource | ||
| Given I'm a collaborator of a certain resource | ||
| When an Owner removes me from the resource as in 'Scenario: Removing a collaborator from a resource' | ||
| Or a Co-Owner removes me from the resource as in 'Scenario: Removing a collaborator from a resource' |
There was a problem hiding this comment.
Or is not allowed.
You need an extra scenario ;-)
There was a problem hiding this comment.
IIRC that "Or" thing was introduced by you here: a60caaf#diff-1c40b780bdbf7746a4b6f27bb29fd912R6
Anyway, will try to change it, thanks.
| Given I'm logged in as a user | ||
| When I have accepted collaborator invites | ||
| Or I have pending collaborator invites as in 'Scenario: Being added as a collaborator to a resource (Pending Shares enabled)' | ||
| Or I have shared resources that I removed from my personal space previously as in 'Feature: Removing a shared resource from a user's personal space' |
| Scenario: Adding a shared resource to a user's personal space | ||
| Given I'm a logged in user | ||
| When I have pending collaborator invites as in 'Scenario: Being added as a collaborator to a resource (Pending Shares enabled)' | ||
| Or I have declined collaborator invites |
| Given I'm a collaborator of a specific resource | ||
| And I have the role 'Owner' | ||
| # Or I have the role 'Co-Owner' | ||
| When looking at the resource in detail |
| Given I'm a collaborator of a specific resource | ||
| And I have the role 'Owner' | ||
| # Or I have the role 'Co-Owner' | ||
| Or I have the permission 'Share' |
| Given I'm a collaborator of a specific resource | ||
| And I have the role 'Owner' | ||
| # Or I have the role 'Co-Owner' | ||
| Or I have the permission 'Share' |
| Scenario: Setting roles for collaborators on a single file | ||
| Given I'm a collaborator of a specific file | ||
| And I have the role 'Owner' | ||
| # Or I have the role 'Co-Owner' |
| Scenario: Setting roles for collaborators on a folder | ||
| Given I'm a collaborator of a specific folder | ||
| And I have the role 'Owner' | ||
| # Or I have the role 'Co-Owner' |
|
Thanks @micbar! Feedback addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the current state of features around collaborators.
Options for autocomplete results=> Not yet implemented => separate PRExtra field to display in autocomplete results=> Not yet implemented => separate PR