Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Add new variations and sizes of progress bar #819

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

LukasHirt
Copy link
Contributor

We've added new variations and sizes of the progress bar component. Variations change the color of the progress bar and can be either primary or warning. Sizes affect the height of the progress bar where it can be either default or small.

@LukasHirt LukasHirt requested a review from kulmann July 28, 2020 07:14
@LukasHirt LukasHirt self-assigned this Jul 28, 2020
src/elements/OcProgress.vue Show resolved Hide resolved
variation: {
type: String,
required: false,
default: "primary"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add validation for allowed variations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 😉

@LukasHirt LukasHirt requested a review from kulmann July 28, 2020 09:26
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LukasHirt LukasHirt merged commit 6b92a14 into master Jul 28, 2020
@LukasHirt LukasHirt deleted the feature/progress-bar-enhancements branch July 28, 2020 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants