This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Add brand colors and xlarge padding token and increase logo clearspace #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
force-pushed
the
oc-branding
branch
2 times, most recently
from
03ad9a7
to
967b886
Compare
Closed
kulmann
previously approved these changes
Jun 16, 2020
There was a problem hiding this comment.
I have two things that I don't fully agree with - but that should be part of further discussion and/or user testing, not of this PR. Will post them separately.
This PR is pure gold. I linked phoenix to this ODS PR and compared the new look with the live demo instance. I love it - most of all the overhauled buttons. ❤️
This was referenced Jun 16, 2020
Added brand colors and xlarge padding token and increase clearspace around logo. Use Source Sans Pro as a global font and redesign buttons.
|
Different buttons size fixed by using the transparent border in primary, secondary and danger button (falling back to default in UIkit). |
micbar
approved these changes
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring oC CI into the default theme, improve buttons design and improve the size of the logo in the sidebar. This PR contains quite a few changes but they're quite small in size so I merged them into one PR.
Related issues: