Sidebar component

[LukasHirt]

Description

Deprecated appNavigation component and created sidebar component.

Screenshot

[kulmann]

This feels awesome. Tested it in your phoenix branch in different resolutions. They made sense as well. One small visual improvement would be, to have a sliding animation, pulling the menu in from the left and pushing it out to the left again on close. Left some small comments for your consideration as well. Overall really nice work 🚀 🎆

[LukasHirt]

@kulmann Pushed fixes after the review and added the animation. Pls re-review 🙂 It's in a separate commit to make it easier to navigate

[kulmann]

Looks super cool! From my point of view the animation could be quicker than 500ms, maybe 200ms.

[LukasHirt]

Looks super cool! From my point of view the animation could be quicker than 500ms, maybe 200ms.

I was trying originally 300 and that seemed too rushed. Since it's moving the whole file list in web app it felt too "jumpy". But that might be just my personal feeling 🙈 I am happy to change it in case you think it really should be faster. 👍

[kulmann]

I played around with the transition duration a bit. I'd prefer 200ms. But try what you think is best and let's get more feedback from different people. ;-)

[LukasHirt]

@kulmann Ok, I changed it to 200 😉

Damn, auto review dismiss, in this situation, it's kind of annoying 😁

[kulmann]

🚀