Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Change remove click event oc icon #2216

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Change remove click event oc icon #2216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e61e2a
Remove unused StatusIndicator component import in OcResource
pascalwengerter May 24, 2022
28ad273
Remove onclick event for OcIon
pascalwengerter Jun 22, 2022
5e9751a
Update changelog item for removed click event on OcIcon
pascalwengerter Jun 22, 2022
4ed2b7a
Add necessary maxwidth to OcNotification class
pascalwengerter Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/bugfix-remove-click-event-oc-icon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Remove click event on OcIcon

We have removed an unnecessary default click handler on the OcIcon component, expecting it to increase performance of the UI.

https://github.com/owncloud/owncloud-design-system/pull/2216
1 change: 1 addition & 0 deletions changelog/unreleased/enhancement-redesign-notifications
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ We have redesigned the notifications component to fit the overal new look of the
It can now also be rendered "unpositioned" instead of having it always stick to the top of the screen.

https://github.com/owncloud/owncloud-design-system/pull/2210
https://github.com/owncloud/owncloud-design-system/pull/2216
https://github.com/owncloud/web/issues/7082
4 changes: 0 additions & 4 deletions src/components/atoms/OcIcon/OcIcon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
sizeClass(size),
variationClass(variation),
]"
@click="onClick"
>
<inline-svg
:src="nameWithFillType"
Expand Down Expand Up @@ -169,9 +168,6 @@ export default {
prefix(string) {
if (string !== null) return `oc-icon-${string}`
},
onClick() {
this.$emit("click")
},
transformSvgElement(svg) {
if (this.accessibleLabel !== "") {
const title = document.createElement("title")
Expand Down
1 change: 1 addition & 0 deletions src/components/atoms/OcNotifications/OcNotifications.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export default {
<style lang="scss">
.oc-notification {
box-sizing: border-box;
max-width: 100%;
width: 400px;
z-index: 1040;

Expand Down
2 changes: 0 additions & 2 deletions src/components/organisms/OcResource/OcResource.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
<script>
import OcButton from "../../atoms/OcButton/OcButton.vue"
import OcImg from "../../atoms/OcImage/OcImage.vue"
import OcStatusIndicators from "../../molecules/OcStatusIndicators/OcStatusIndicators.vue"
import OcIcon from "../../atoms/OcIcon/OcIcon.vue"
import OcResourceName from "../../atoms/OcResourceName/OcResourceName.vue"
import OcResourceIcon from "../../atoms/OcResourceIcon/OcResourceIcon.vue"
Expand All @@ -78,7 +77,6 @@ export default {
components: {
OcButton,
OcImg,
OcStatusIndicators,
OcIcon,
OcResourceName,
OcResourceIcon,
Expand Down