Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Performance improvements in OcTable #2165

Closed
wants to merge 2 commits into from

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented May 24, 2022

Description

Introduce v-once and cut unnecessary events and Vue.js component usage to complement owncloud/web#7056

I've removed some OcTable helper components in favor of native HTML table tags - this should reduce rerendering/observing/general UI overhead. It also removes the shimmer effect on table cell load (previews get fetched lazily anyways)

@update-docs
Copy link

update-docs bot commented May 24, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😍 please make sure to raise a breaking change via changelog item. ;-) Also, please check if we're using the OcTableSimple somewhere because those usages will need to be adapted to not use the table building blocks you deleted here but use native html tags instead.

@pascalwengerter pascalwengerter force-pushed the performance-improvements branch 2 times, most recently from c9e6d83 to d593dac Compare June 27, 2022 15:09
@pascalwengerter pascalwengerter changed the title Performance improvements Performance improvements in OcTable Jun 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter marked this pull request as ready for review June 27, 2022 15:11
@pascalwengerter
Copy link
Contributor Author

Needs a re-visit since table-cell formatting is broken 🙄

@kulmann
Copy link
Member

kulmann commented Jul 19, 2022

Superseded by #2260 as it turns out that the debounce in lazy loading (which was also removed in this PR) was a big performance issue.

@kulmann kulmann closed this Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants