This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
OcButton: Change default type of buttons to button #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dschmidt
force-pushed
the
make_oc_buttons_of_type_button_by_default
branch
2 times, most recently
from
3a56265
to
bc3e4ce
Compare
dschmidt
changed the title
dschmidt
force-pushed
the
make_oc_buttons_of_type_button_by_default
branch
from
bc3e4ce
to
d6aaedf
Compare
|
Kudos, SonarCloud Quality Gate passed! |
10 tasks
delete-merged-branch
bot
deleted the
make_oc_buttons_of_type_button_by_default
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the default type of
OcButtontobutton.The default type for
<button>elements issubmit. As we use it all over the place now for a11y reasons, we have lots and lots of submit buttons everywhere, which is most likely not what we want.Related Issue
Could not find an open ticket for this issue.
Motivation and Context
I recently noticed that pressing enter in one of the text inputs in the public link editing view opened the datepicker instead of saving the link:
liveview-2022-03-07_22.14.14.mp4
It was @fschade (💖 ) who pointed me towards the root of the issue:
pressing enter submits the form, which automatically clicks the first (at least in chromium) button which is not of type "button". In this case this happened to be the button that opens the datepicker.
Now I would argue that more often than not buttons should not behave as submit buttons and we should instead mark submit buttons explicitly. As there are only a few occurences of
<formin oC Web, this change should not be too invasive...How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: