Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Make OcDrop rounded / Improve OcList #1881

Merged
merged 13 commits into from
Jan 25, 2022
Merged

Make OcDrop rounded / Improve OcList #1881

merged 13 commits into from
Jan 25, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jan 13, 2022 •
edited
Loading

Description

We've added a border-radius for the OcDrop
to make it rounded.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@update-docs
Copy link

update-docs bot commented Jan 13, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review January 13, 2022 15:55
@lookacat lookacat force-pushed the feat-rounded-ocdrop branch 2 times, most recently from 82523d6 to 9f8ea1f Compare January 13, 2022 15:58
@lookacat lookacat changed the title OcDrop rounded prop Make OcDrop rounded Jan 17, 2022
@lookacat lookacat changed the title Make OcDrop rounded Make OcDrop rounded / Enhance OcList Jan 18, 2022
@lookacat lookacat changed the title Make OcDrop rounded / Enhance OcList Make OcDrop rounded / Improve OcList Jan 18, 2022
kulmann
kulmann suggested changes Jan 18, 2022
View reviewed changes
src/components/atoms/OcDrop/OcDrop.vue Outdated Show resolved Hide resolved
src/components/atoms/OcDrop/OcDrop.vue Outdated Show resolved Hide resolved
src/components/atoms/OcList/OcList.vue Outdated Show resolved Hide resolved
@lookacat lookacat requested a review from kulmann January 18, 2022 11:47
kulmann
kulmann approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Jan 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pascalwengerter
Copy link
Contributor

@lookacat @kulmann anything left to merge & alpha-release this one? :)

@kulmann
Copy link
Member

kulmann commented Jan 24, 2022

@lookacat @kulmann anything left to merge & alpha-release this one? :)

Good to merge and release from my side.

@lookacat lookacat merged commit acd80ea into master Jan 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat-rounded-ocdrop branch January 25, 2022 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter pascalwengerter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookacat @pascalwengerter @kulmann