Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Minor code style and docs improvements #1795

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Nov 23, 2021

Found some small chances for improvement in ODS...

@update-docs
Copy link

update-docs bot commented Nov 23, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann self-assigned this Nov 23, 2021
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps could use a changelog item since you removed the stopClassPropagation in two components, but wouldn't bother with a breaking change (unless we decide to remove UiKit and maybe streamline the form inputs before the next release). Other than that LGTM, thanks for taking care!

@kulmann
Copy link
Member Author

kulmann commented Nov 23, 2021

Perhaps could use a changelog item since you removed the stopClassPropagation in two components, but wouldn't bother with a breaking change (unless we decide to remove UiKit and maybe streamline the form inputs before the next release). Other than that LGTM, thanks for taking care!

Thanks, I added a changelog item. Indeed a change item - although it seems to be not that important. If we don't manage to remove UiKit until the next release we could think about reverting stuff in the release branch...

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In favor of merging this one and then going for UiKit soon-ish too so we can have a bunch of change items in one release

@kulmann kulmann merged commit d4309c7 into master Dec 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the code-style-improvements branch December 6, 2021 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants