This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
refactor(pagination): use route query object instead of param #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of having current pagination page as param refactor it to use the query route object BREAKING CHANGE: this could break in some cases where the implementing logic relies on route page param, to fix switch to use route query object
kulmann
reviewed
Sep 2, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
kulmann
approved these changes
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of having current pagination page as param refactor it to
use the query route object
BREAKING CHANGE: this could break in some cases where the implementing
logic relies on route page param, to fix switch to use route query
object