Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Prepare 9.3.0 release #1610

Merged
merged 7 commits into from
Aug 23, 2021
Merged

Prepare 9.3.0 release #1610

merged 7 commits into from
Aug 23, 2021

Conversation

pascalwengerter
Copy link
Contributor

Description

Sorry this one escalated a bit (on the positive side of things 🤓 )

Related Issue

@update-docs
Copy link

update-docs bot commented Aug 23, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter pascalwengerter mentioned this pull request Aug 23, 2021
Closed
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

23.1% 23.1% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a little bit too radical. ;-) I took the liberty of re-introducing emitting a new selection model on context menu click. Otherwise we don't have the correct selection model available for further actions. Also rebased to include another (now merged) PR.
Cool! Feels like a good collection of things for a release 😎

@kulmann kulmann merged commit 7873ee0 into master Aug 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the prepare-9.3.0-release branch August 23, 2021 21:31
@pascalwengerter
Copy link
Contributor Author

Was a little bit too radical. ;-) I took the liberty of re-introducing emitting a new selection model on context menu click. Otherwise we don't have the correct selection model available for further actions. Also rebased to include another (now merged) PR.
Cool! Feels like a good collection of things for a release sunglasses

Nice improvements, thanks for taking care!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files row menu is opening sidebar
2 participants
@pascalwengerter @kulmann