Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] optimize dependency generation #964

Merged
merged 1 commit into from
Nov 27, 2020
Merged

[tests-only] optimize dependency generation #964

merged 1 commit into from
Nov 27, 2020

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 27, 2020 •
edited
Loading

In my view it is better to generate dependencies from the pipeline itselves, since this deduplicates code (the generation of the list of names is really similar to pipeline generation itself). It also ensures that generated dependencies and the actually generated pipelines are always the same. This might not the case with a separate generation like it is now.

@sonarcloud
Copy link

sonarcloud bot commented Nov 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek marked this pull request as ready for review November 27, 2020 08:29
@phil-davis phil-davis changed the title optimize dependency generation [tests-only] optimize dependency generation Nov 27, 2020
@owncloud owncloud deleted a comment from update-docs bot Nov 27, 2020
phil-davis
phil-davis approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing this. The "magic" pipeline-name-generation functions were a nuisance because when someone changed the pipelines, they also had to hack the pipeline-name-generation functions to match. Now it will "just work"

@phil-davis phil-davis merged commit d37701e into master Nov 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the Ci_optimize_dependency_generation branch November 27, 2020 09:28
ownclouders pushed a commit that referenced this pull request Nov 27, 2020
@phil-davis
commit d37701e
5f032a6 
Merge: 6d3dc1c deeb9a8
Author: Phil Davis <phil@jankaritech.com>
Date:   Fri Nov 27 15:13:42 2020 +0545

    Merge pull request #964 from owncloud/Ci_optimize_dependency_generation

    [tests-only] optimize dependency generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @phil-davis