Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce middleware complexity #859

Merged
merged 8 commits into from
Nov 17, 2020
Merged

reduce middleware complexity #859

merged 8 commits into from
Nov 17, 2020

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Nov 16, 2020

  • refactor middlewares and reduce technical complexity
  • restructure server command and remove cfg.OIDC.Issuer switch, oidc middleware detects now if it should used or not
  • fix cannot download a file with phoenix #761

@fschade fschade requested a review from C0rby November 16, 2020 13:02
kulmann
kulmann reviewed Nov 16, 2020
View reviewed changes
proxy/pkg/command/server.go Outdated

// the connection will be established in a non blocking fashion
sc, err := cs3.GetGatewayServiceClient(cfg.Reva.Address)
accountsClient := acc.NewAccountsService("com.owncloud.api.accounts", mclient.DefaultClient)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaict all occurrences of mclient.DefaultClient should now be replaced with grpc.DefaultClient, with the grpc package coming from "github.com/owncloud/ocis/ocis-pkg/service/grpc", as of #840

@fschade fschade marked this pull request as ready for review November 16, 2020 18:00
@fschade fschade changed the title [tests-only] reduce middleware complexity reduce middleware complexity Nov 17, 2020
Florian Schade added 4 commits November 17, 2020 11:32
@kulmann kulmann mentioned this pull request Nov 17, 2020
Closed
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IljaN IljaN self-requested a review November 17, 2020 14:10
@kulmann kulmann merged commit 1034548 into master Nov 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the refactor-middlewares branch November 17, 2020 14:34
ownclouders pushed a commit that referenced this pull request Nov 17, 2020
@kulmann
commit 1034548
af19797 
Merge: 2d5401d e0f4c69
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Tue Nov 17 15:34:05 2020 +0100

    Merge pull request #859 from owncloud/refactor-middlewares

    reduce middleware complexity
@C0rby C0rby mentioned this pull request Nov 20, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann left review comments

@C0rby C0rby C0rby left review comments

@IljaN IljaN IljaN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot download a file with phoenix
4 participants
@fschade @IljaN @kulmann @C0rby