verify all system accounts are set #8546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
verify-service-accounts-are-set
branch
from
b71230e
to
8f9287b
Compare
2403905
approved these changes
Feb 29, 2024
|
Should we also validate for the ocis/services/ocm/pkg/config/config.go Line 61 in 4427c9f |
|
related: #8107 |
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
verify-service-accounts-are-set
branch
from
8f9287b
to
972adaf
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
|
init does not set the service account for ocm, so this needs to go into v5 as well |
|
|
@2403905 thx, added, please rereview |
ownclouders
pushed a commit
that referenced
this pull request
Feb 29, 2024
verify all system accounts are set
|
please backport to stable-5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while we are configuring them in ocis init, we are not verifying if they are set. This allows the service to start with a broken configuration that leads to failing requests.