Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Add tests to list same name resources shared by user from two project-spaces with him/her #8516

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[tests-only][full-ci] Add tests to list same name resources shared by user from two project-spaces with him/her #8516

merged 1 commit into from
Feb 29, 2024

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Feb 23, 2024 •
edited
Loading

Description

In this PR following scenarios are added related to sharingNG:

- user lists the file with same name shared by user from two project-spaces with him/her
- user lists the folder with same name shared by user from two project-spaces with him/her

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Feb 23, 2024
@nabim777 nabim777 changed the title [tests-only][full-ci] Add tests to list project spaces resources shared by two users with h… [tests-only][full-ci] Add tests to list project spaces resources shared by two users with him/her Feb 23, 2024
@nabim777 nabim777 changed the title [tests-only][full-ci] Add tests to list project spaces resources shared by two users with him/her [tests-only][full-ci] Add tests to list project spaces resources shared by user from two project-spaces with him/her Feb 23, 2024
@nabim777 nabim777 changed the title [tests-only][full-ci] Add tests to list project spaces resources shared by user from two project-spaces with him/her [tests-only][full-ci] Add tests to list resources shared by user from two project-spaces with him/her Feb 23, 2024
@nabim777 nabim777 force-pushed the tests/share-entity-with-same-name-sync-disable branch from ebdcd2f to ed5ec7b Compare February 23, 2024 10:43
@nabim777 nabim777 force-pushed the tests/share-entity-with-same-name-sync-disable branch from ed5ec7b to 032cf2a Compare February 26, 2024 04:02
@nabim777 nabim777 changed the title [tests-only][full-ci] Add tests to list resources shared by user from two project-spaces with him/her [tests-only][full-ci] Add tests to list same name resources shared by user from two project-spaces with him/her Feb 26, 2024
@nabim777 nabim777 mentioned this pull request Feb 26, 2024
Closed
12 tasks
@saw-jan
Copy link
Member

saw-jan commented Feb 26, 2024

Please, make changes to json schema

'items' should be an object when expecting 1 element
Failed asserting that false is true.

@nabim777 nabim777 force-pushed the tests/share-entity-with-same-name-sync-disable branch from 032cf2a to cb247f9 Compare February 27, 2024 05:40
@nabim777 nabim777 force-pushed the tests/share-entity-with-same-name-sync-disable branch 2 times, most recently from 5241d11 to d8ca803 Compare February 27, 2024 09:25
@nabim777 nabim777 force-pushed the tests/share-entity-with-same-name-sync-disable branch from d8ca803 to c63d568 Compare February 27, 2024 10:21
@nabim777 nabim777 force-pushed the tests/share-entity-with-same-name-sync-disable branch from c63d568 to ebe7ad6 Compare February 28, 2024 04:24
saw-jan
saw-jan approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabim777 nabim777 force-pushed the tests/share-entity-with-same-name-sync-disable branch from ebe7ad6 to 1167506 Compare February 28, 2024 11:27
@nabim777 nabim777 force-pushed the tests/share-entity-with-same-name-sync-disable branch from 1167506 to 83aeedd Compare February 29, 2024 03:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nabim777 nabim777 merged commit 4427c9f into master Feb 29, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/share-entity-with-same-name-sync-disable branch February 29, 2024 06:26
ownclouders pushed a commit that referenced this pull request Feb 29, 2024
@nabim777
add tests to list peoject spaces resources shared by two users with h…
2cf7f2c 
…im/her (#8516)
rhafer pushed a commit to rhafer/ocis that referenced this pull request Mar 12, 2024
@nabim777 @rhafer
add tests to list peoject spaces resources shared by two users with h…
7abce5b 
…im/her (owncloud#8516)

(cherry picked from commit 4427c9f)
@rhafer rhafer mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@PrajwolAmatya PrajwolAmatya PrajwolAmatya approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nabim777 @saw-jan @PrajwolAmatya @nirajacharya2