Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing resources with same name auto sync disabled #8449

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Sharing resources with same name auto sync disabled #8449

merged 3 commits into from
Feb 21, 2024

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Feb 14, 2024 •
edited
Loading

Description

Added scenario:

  • Scenario: user lists the file with same name shared by two users with him/her
  • Scenario: user lists the folder with same name shared by two users with him/her

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Feb 14, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@grgprarup grgprarup marked this pull request as draft February 14, 2024 11:22
@grgprarup grgprarup self-assigned this Feb 14, 2024
@grgprarup grgprarup mentioned this pull request Feb 20, 2024
Closed
12 tasks
@grgprarup grgprarup force-pushed the sharing-resources-with-same-name-auto-sync-disabled branch from 61d6199 to aa67452 Compare February 20, 2024 11:14
@grgprarup grgprarup marked this pull request as ready for review February 20, 2024 11:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

PrajwolAmatya
PrajwolAmatya approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup merged commit 5a7d498 into master Feb 21, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sharing-resources-with-same-name-auto-sync-disabled branch February 21, 2024 04:12
ownclouders pushed a commit that referenced this pull request Feb 21, 2024
@grgprarup
Merge pull request #8449 from owncloud/sharing-resources-with-same-na…
02b9d29 
…me-auto-sync-disabled

Sharing resources with same name auto sync disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwolAmatya PrajwolAmatya PrajwolAmatya approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@saw-jan saw-jan Awaiting requested review from saw-jan

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grgprarup @PrajwolAmatya