Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Make graph api default in test #8290

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jan 26, 2024

Description

In this PR, the graph API is made the default API while testing. Also, this function isTestingWithGraphApi() is removed

Related Issue

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Jan 26, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@nabim777 nabim777 changed the title make graph api default in test [tests-only][full-ci] Make graph api default in test Jan 26, 2024
@nabim777 nabim777 self-assigned this Jan 26, 2024
@nabim777 nabim777 modified the milestone: https://github.com/owncloud/ocis/issues/8276 Jan 26, 2024
@nabim777 nabim777 force-pushed the make-default-graph-api branch 3 times, most recently from 52664cf to afada02 Compare January 29, 2024 05:15
@nabim777 nabim777 marked this pull request as ready for review January 29, 2024 05:28
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please, check if ocis bump in reva works as well

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nabim777
Copy link
Member Author

check in Reva cs3org/reva#4484

@nabim777 nabim777 merged commit d73351a into master Jan 30, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the make-default-graph-api branch January 30, 2024 11:30
ownclouders pushed a commit that referenced this pull request Jan 30, 2024
* make graph api default in test

* skip quota test in reva
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants