[tests-only][full-ci] Added test to reshare a resource to other users with higher roles #8147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
PrajwolAmatya
force-pushed
the
test-reshare-to-higher-roles-sharingNg
branch
2 times, most recently
from
e8d6e63
to
bf9d938
Compare
|
The resharing feature is expected to be dropped, as mentioned in the comment. So, we don't add new tests for resharing. |
This was referenced Jan 25, 2024
PrajwolAmatya
force-pushed
the
test-reshare-to-higher-roles-sharingNg
branch
from
bf9d938
to
ded8edd
Compare
PrajwolAmatya
requested review from
grgprarup,
SagarGi,
saw-jan,
Salipa-Gurung and
amrita-shrestha
PrajwolAmatya
force-pushed
the
test-reshare-to-higher-roles-sharingNg
branch
from
ded8edd
to
d0d7cbd
Compare
|
saw-jan
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
LGTM
@ScharfViktor we will only add this reshare test and we will not add any reshare tests until next decision
ScharfViktor
approved these changes
Jan 25, 2024
delete-merged-branch
bot
deleted the
test-reshare-to-higher-roles-sharingNg
branch
ownclouders
pushed a commit
that referenced
this pull request
Jan 25, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added test to reshare a resource to other users with higher role, for example, user receives a share with role
Viewerand tries to reshare the resource with roleEditor, which should not be possible. Likewise, a user receiving share with roleUploadershould not have permission to reshare a resource.Expected: resharing should not happen and should return status code
403Added Scenarios:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: