Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Added test for sending share invitation to wrong objectId #8129

Merged
merged 2 commits into from
Jan 25, 2024
Merged

[full-ci] [tests-only] Added test for sending share invitation to wrong objectId #8129

merged 2 commits into from
Jan 25, 2024

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Jan 4, 2024 •
edited
Loading

Description

Added scenarios:

  • Scenario Outline: send share invitation to wrong user id

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup mentioned this pull request Jan 4, 2024
Closed
36 tasks
@grgprarup grgprarup self-assigned this Jan 5, 2024
@grgprarup grgprarup changed the title [full-ci] [tests-only] Added test for sending share invitation to wrong user id [full-ci] [tests-only] Added test for sending share invitation to wrong objectId Jan 5, 2024
@grgprarup grgprarup marked this pull request as draft January 5, 2024 09:47
@grgprarup grgprarup force-pushed the add-test-for-invite-user-with-wrong-objectId branch from 7243492 to 619fc72 Compare January 23, 2024 08:41
@grgprarup grgprarup changed the base branch from stable-5.0 to master January 23, 2024 08:41
@grgprarup grgprarup closed this Jan 23, 2024
@grgprarup grgprarup force-pushed the add-test-for-invite-user-with-wrong-objectId branch from 619fc72 to ee931c9 Compare January 23, 2024 08:43
@grgprarup grgprarup reopened this Jan 23, 2024
@grgprarup grgprarup force-pushed the add-test-for-invite-user-with-wrong-objectId branch from 3ba6ed6 to 988a558 Compare January 24, 2024 08:50
@grgprarup grgprarup marked this pull request as ready for review January 24, 2024 08:50
@grgprarup grgprarup force-pushed the add-test-for-invite-user-with-wrong-objectId branch from 988a558 to c937838 Compare January 25, 2024 08:32
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

saw-jan
saw-jan approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grgprarup grgprarup merged commit 5d96e9b into master Jan 25, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-test-for-invite-user-with-wrong-objectId branch January 25, 2024 11:20
ownclouders pushed a commit that referenced this pull request Jan 25, 2024
@grgprarup
Merge pull request #8129 from owncloud/add-test-for-invite-user-with-…
23ebabd 
…wrong-objectId

[full-ci] [tests-only] Added test for sending share invitation to wrong objectId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grgprarup @saw-jan