Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] added test to check group members have received shares using me/drive/sharedWithMe #8072

Closed
wants to merge 6 commits into from

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Dec 27, 2023

Description

In this PR, added test to share resource with diffrent roles using new sharing Graph API and, check if the member of group have received shares using me/drive/sharedWithMe.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya
Copy link
Contributor Author

PrajwolAmatya commented Dec 27, 2023

wait for merge of PR: #8010 and #8047

Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@PrajwolAmatya
Copy link
Contributor Author

PrajwolAmatya commented Jan 15, 2024

wait for merge of PR: #8010 and #8047

currently this PR uses the step definition which adds by #8010 (blocked state) as mentioned in this comment #8010 (comment). So this PR is blocked for now

@PrajwolAmatya
Copy link
Contributor Author

PrajwolAmatya commented Jan 23, 2024

Previously, checked the response from me/drives/sharedWithMe after sharing to normal user or group, but later as discussed in comment #8114 (comment), we only check resource availability. Test for normal group was covered in #8226. So, closing this PR.

@PrajwolAmatya PrajwolAmatya deleted the invite-normal-groups branch January 23, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants