Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] refactored feature file related to GraphAPI steps #7372

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[tests-only] [full-ci] refactored feature file related to GraphAPI steps #7372

merged 1 commit into from
Oct 11, 2023

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Sep 27, 2023 •
edited
Loading

Description

This PR refactors the user creation feature file steps so that all the steps used in the entire file will be coherent and meaningful. No test code is changed in the process.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@S-Panta S-Panta force-pushed the refactoring-user-creation-feature-file branch 2 times, most recently from 1232468 to 7644a62 Compare September 28, 2023 03:33
@S-Panta S-Panta self-assigned this Sep 28, 2023
@S-Panta S-Panta changed the title [tests-only] [full-ci] refactored user creation feature file steps [tests-only] [full-ci] refactored feature file related to GraphAPI steps Sep 29, 2023
@S-Panta S-Panta closed this Sep 29, 2023
@S-Panta S-Panta deleted the refactoring-user-creation-feature-file branch September 29, 2023 08:24
@S-Panta S-Panta restored the refactoring-user-creation-feature-file branch September 29, 2023 08:26
@S-Panta S-Panta reopened this Sep 29, 2023
@S-Panta S-Panta force-pushed the refactoring-user-creation-feature-file branch 4 times, most recently from 6412eae to 0ffd3c2 Compare September 29, 2023 09:35
@S-Panta S-Panta force-pushed the refactoring-user-creation-feature-file branch from 0ffd3c2 to 6517995 Compare October 11, 2023 05:54
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@S-Panta S-Panta marked this pull request as ready for review October 11, 2023 09:37
saw-jan
saw-jan approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✨

@saw-jan saw-jan merged commit 3720813 into master Oct 11, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactoring-user-creation-feature-file branch October 11, 2023 10:10
ownclouders pushed a commit that referenced this pull request Oct 11, 2023
@S-Panta
addressing the review (#7372)
f2b220a
@S-Panta S-Panta mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@S-Panta S-Panta

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S-Panta @saw-jan