-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] refactoring user creation Given
steps (#7019)
#7259
Merged
saw-jan
merged 1 commit into
stable-4.0
from
backport/refactoring-user-creation-testcode-to-graphapi
Sep 11, 2023
Merged
[tests-only][full-ci] refactoring user creation Given
steps (#7019)
#7259
saw-jan
merged 1 commit into
stable-4.0
from
backport/refactoring-user-creation-testcode-to-graphapi
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovisioning into GraphContext (#7019) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
2 tasks
Kudos, SonarCloud Quality Gate passed! |
saw-jan
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
saw-jan
changed the title
[tests-only][full-ci] refactoring user creation
[tests-only][full-ci] refactoring user creation Sep 11, 2023
Given
steps from pr…Given
steps (#7019)
SagarGi
approved these changes
Sep 11, 2023
delete-merged-branch
bot
deleted the
backport/refactoring-user-creation-testcode-to-graphapi
branch
September 11, 2023 09:17
ownclouders
pushed a commit
that referenced
this pull request
Sep 11, 2023
…ovisioning into GraphContext (#7019) (#7259) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
ownclouders
pushed a commit
that referenced
this pull request
Sep 12, 2023
…ovisioning into GraphContext (#7019) (#7259) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
ownclouders
pushed a commit
that referenced
this pull request
Sep 12, 2023
…ovisioning into GraphContext (#7019) (#7259) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
ownclouders
pushed a commit
that referenced
this pull request
Sep 12, 2023
…ovisioning into GraphContext (#7019) (#7259) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
ownclouders
pushed a commit
that referenced
this pull request
Sep 13, 2023
…ovisioning into GraphContext (#7019) (#7259) * refactored the user creation given statement from provisioning to graph api added getUser steps that covers the steps for user with user light role * added userlight step tests to check drive information and updated expected failure files * added usercreation initiation code * deleted seperate tests for user light role * remove unnecesary changes * add user not initialize step * corrected the testcode * moved the steps from graph to provisioning file * fix creating single ldap user * fix: user check method * initialize user via graph * addressing reviews --------- Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports to #7019