Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add lock related tests for /Shares on ocis #4404

Merged
merged 3 commits into from
Aug 31, 2022
Merged

[tests-only][full-ci]Add lock related tests for /Shares on ocis #4404

merged 3 commits into from
Aug 31, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Aug 17, 2022

Description

This PR adds the tests for lock properties for reshared shares to share related to /Shares which is removed from this PR https://github.com/owncloud/core/pull/40290/files as /Shares related implementation is not in core and is shifted to ocis.

Related issue

#4154 (comment)

@SagarGi SagarGi self-assigned this Aug 17, 2022
@SagarGi SagarGi mentioned this pull request Aug 18, 2022
Closed
2 tasks
@SagarGi SagarGi force-pushed the addTestForWebdavlockforResharedSharesToShares branch 3 times, most recently from 862f226 to b57801d Compare August 18, 2022 08:14
@SagarGi SagarGi mentioned this pull request Aug 19, 2022
Closed
@SagarGi SagarGi force-pushed the addTestForWebdavlockforResharedSharesToShares branch 4 times, most recently from 5c87ef4 to 0c46e3c Compare August 22, 2022 10:07
@SagarGi SagarGi force-pushed the addTestForWebdavlockforResharedSharesToShares branch from 0c46e3c to 1754904 Compare August 22, 2022 10:35
@SagarGi SagarGi marked this pull request as ready for review August 22, 2022 10:35
@SagarGi SagarGi force-pushed the addTestForWebdavlockforResharedSharesToShares branch from 1754904 to 96677a6 Compare August 23, 2022 05:44
@SagarGi SagarGi force-pushed the addTestForWebdavlockforResharedSharesToShares branch from 96677a6 to bb9f0ca Compare August 24, 2022 03:36
@phil-davis phil-davis changed the title [tests-only][full-ci]Add lock realated tests for /Shares on ocis [tests-only][full-ci]Add lock related tests for /Shares on ocis Aug 24, 2022
@SagarGi SagarGi force-pushed the addTestForWebdavlockforResharedSharesToShares branch from bb9f0ca to 99d5c80 Compare August 24, 2022 06:01
saw-jan
saw-jan reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@SagarGi SagarGi force-pushed the addTestForWebdavlockforResharedSharesToShares branch from 7e536f6 to 90d9c26 Compare August 26, 2022 08:29
@SagarGi SagarGi force-pushed the addTestForWebdavlockforResharedSharesToShares branch from 90d9c26 to e125782 Compare August 29, 2022 10:21
@SagarGi SagarGi requested a review from SwikritiT August 29, 2022 10:21
@SagarGi SagarGi force-pushed the addTestForWebdavlockforResharedSharesToShares branch 2 times, most recently from 2e7b6c0 to 2f1d458 Compare August 30, 2022 03:30
@SagarGi SagarGi force-pushed the addTestForWebdavlockforResharedSharesToShares branch from 2f1d458 to d50ccd3 Compare August 30, 2022 05:44
kiranparajuli589
kiranparajuli589 reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@SagarGi SagarGi force-pushed the addTestForWebdavlockforResharedSharesToShares branch from d50ccd3 to f12aa29 Compare August 31, 2022 03:51
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it merged commit f9cd1f5 into master Aug 31, 2022
@delete-merged-branch delete-merged-branch bot deleted the addTestForWebdavlockforResharedSharesToShares branch August 31, 2022 07:12
ownclouders pushed a commit that referenced this pull request Aug 31, 2022
@SagarGi
commit f9cd1f5
be7149a 
Author: Sagar Gurung <46086950+SagarGi@users.noreply.github.com>
Date:   Wed Aug 31 12:57:15 2022 +0545

    [tests-only][full-ci]Add lock related tests for `/Shares` on ocis (#4404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@saw-jan saw-jan saw-jan left review comments

@individual-it individual-it individual-it approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@sushmita56 sushmita56 Awaiting requested review from sushmita56

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@grgprarup grgprarup Awaiting requested review from grgprarup

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SagarGi @individual-it @grgprarup @kiranparajuli589 @SwikritiT @saw-jan @amrita-shrestha