Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add /Shares related move tests on ocis which are removed from core #4400

Merged
merged 2 commits into from
Sep 9, 2022
Merged

[tests-only][full-ci]Add /Shares related move tests on ocis which are removed from core #4400

merged 2 commits into from
Sep 9, 2022

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR adds the tests for move properties related to /Shares which is removed from this PR owncloud/core#40294 as /Shares related implementation is not in core and is shifted to ocis.

Related issue

#4154 (comment)

@amrita-shrestha amrita-shrestha self-assigned this Aug 17, 2022
@amrita-shrestha amrita-shrestha mentioned this pull request Aug 17, 2022
Closed
2 tasks
@amrita-shrestha amrita-shrestha marked this pull request as ready for review August 29, 2022 08:45
@amrita-shrestha amrita-shrestha force-pushed the addMoveSpacesTestsOnOcis branch 2 times, most recently from 7bbcb49 to 3a4940a Compare September 1, 2022 09:30
SagarGi
SagarGi reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

.drone.env Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the addMoveSpacesTestsOnOcis branch 3 times, most recently from a56de1c to d14d36a Compare September 5, 2022 08:28
@amrita-shrestha amrita-shrestha force-pushed the addMoveSpacesTestsOnOcis branch 2 times, most recently from b1e2ee0 to e76aae7 Compare September 5, 2022 10:15
SagarGi
SagarGi reviewed Sep 5, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM 👍

tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
@amrita-shrestha
Copy link
Contributor Author

Blocked until these changes pulled to ocis cs3org/reva#3195

@SagarGi
Copy link
Member

SagarGi commented Sep 8, 2022 •
edited
Loading

Blocked until these changes pulled to ocis cs3org/reva#3195

Please rebase and push. It has been fixed. Lets make CI green again

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

grgprarup
grgprarup approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@phil-davis phil-davis merged commit 50471af into master Sep 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the addMoveSpacesTestsOnOcis branch September 9, 2022 08:15
ownclouders pushed a commit that referenced this pull request Sep 9, 2022
@phil-davis
commit 50471af
f90c17e 
Merge: 979da92 e0201c8
Author: Phil Davis <phil@jankaritech.com>
Date:   Fri Sep 9 14:00:49 2022 +0545

    Merge pull request #4400 from owncloud/addMoveSpacesTestsOnOcis

    [tests-only][full-ci]Add /Shares related move tests on ocis which are removed from core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@phil-davis phil-davis phil-davis approved these changes

@grgprarup grgprarup grgprarup approved these changes

@SagarGi SagarGi SagarGi approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amrita-shrestha @SagarGi @phil-davis @grgprarup @kiranparajuli589 @saw-jan